Maxime Curioni

Results 31 comments of Maxime Curioni

> @max-ipinfo is it OK now? Sorry @rvalitov for my latency. I am planning on taking a final look. Once that's done, I'll approve and will submit your PR to...

Hi @tdltdl ! Thanks for your 3 PRs. We will go over them as soon as we have a chance.

@tdltdl sorry for the wait. My hope is to take some time tomorrow, February 21 2025, to look at your PRs. I'll keep you posted!

@tdltdl starting the review of the 3 PRs now. I'll keep you posted there directly.

@tdltdl let's focus on PR #55 for now. Sent you a first review: https://github.com/ipinfo/java/pull/55#pullrequestreview-2634504332

> Unit test fixes are here... So doing them in the wrong order forces us to do the same test fixes multiple times Sorry @tdltdl, I didn't understand your comment...

@v-prasadboke could you provide an update whether you need any changes from us (IPinfo)? I will be continuing @AhmadMujahid2k's work moving forward. Thank you!

I updated all references to Python to version 3.11: https://github.com/Azure/Azure-Sentinel/pull/10981/commits/4ab1e11b0f625c20a0142dfd815f5c1159a750c0 @v-prasadboke are there any other remaining steps you would like me to perform?

@v-prasadboke could you provide an update? We are blocked on this PR to release our Solution offering to our customers. Thank you.

@v-prasadboke regarding your error, I was trying to address your comment asking us to upgrade to Python 3.11. All I did in https://github.com/Azure/Azure-Sentinel/pull/10981/commits/4ab1e11b0f625c20a0142dfd815f5c1159a750c0 is changing `"linuxFxVersion"` from `"Python|3.10"` to `"Python|3.11"`....