Maximilian Hoffman

Results 64 issues of Maximilian Hoffman

I think the count of a primary key and count of a unique index with all non-nullable columns should both equivalent to `count(*)`: ```sql create table xyz (x int primary...

sql
performance
analyzer

This PR adds custom Dolt execution operators for lookup joins. When building an execution plan, we try to replace `joinIter` with a Dolt equivalent that inlines the key building and...

There was an issue merging https://github.com/dolthub/dolt/pull/8025 ontop of a revert. Enable the key iteration optimization.

correctness_approved

Renaming the default branch (`call dolt_branch('-m', 'main', 'master');`) does not set the config `init.defaultbranch` branch param, making `DoltDatabaseProvider.defaultBranch` invalid for (1) the current session, (2) the engine + all subsequent...

bug
good first issue
configuration

When implementing `Range.KeyRangeLookup`, some of the tests panicked because `len(Range.Fields) != Range.Desc.Count()`. I worked around the problem but did not dig into why this is the case. It seems suspicious...

enhancement
question
sql

Dolt silently fails to load databases sometimes, for example permission reasons (example below). I would have preferred `dolt sql` (or anything that starts an engine) to at least warn me...

bad error message
sql server

Three main changes: - stats use floats by default, to avoid uint->float round tripping - bucket MCVs are assumed to be sorted - MCVs are discarded if they are not...

`call dolt_stats_prune()` should wipe the stats database disk contents, and replace with the currently tracked statistics. This is GC-like behavior. `call dolt_stats_purge()` should clear the stats database folder and reinitialize...

correctness_approved

correctness_approved

Exporting invalid CSV makes it hard to roundtrip import/exports. Small repro: ```bash dolt init dolt sql

bug