Maximilian Hoffman

Results 64 issues of Maximilian Hoffman

The old count aggregate logic uses `*expression.Star` during evaluation, and explicitly ignores the expression for resolving: ``` func (a *unaryAggBase) Resolved() bool { if _, ok := a.Child.(*expression.Star); ok {...

bug
analyzer

Version: ``` > dolt version dolt version 0.24.4 ``` Working query: ``` > dolt sql -q " with t as ( select case when p1.pred = p2.actual then 1 else...

bug
sql

I am not sure this `DiffTableFunctionScriptTest` should succeed. The table/column resolving should be ambiguous. ```sql SELECT to_pk, to_c1, to_c2, from_pk, from_c1, from_c2, diff_type from dolt_diff(@Commit1, @Commit2, 't') join dolt_diff(@Commit1, @Commit3,...

bug
sql

The diff table generates `commit` and `date` columns with `to_` and `from_` prefixes, for example `to_commit` and `from_commit`. Those generated columns ids are important for filters and project expressions. A...

bug
sql

expected behavior: - `dolt diff table` should filter output based on table's namespace actual behavior: - added table specifier creates empty diff reproducing: - database/table created with doltpy ```python3 import...

bug
good first issue
cli
diff

There's one root chunk for an empty table that needs special handling because there is no histogram bucket for it.

correctness_approved

CREATE and ALTER statements ignore autocommit transactions in MySQL. They do not commit the working set, but they are immediately available to other sessions - CREATE table is immediately visible...

sql
transactions

We return nil results for empty procedures, mysql appears to error: ```sql DELIMITER // CREATE PROCEDURE eof() BEGIN DECLARE a, b INT DEFAULT 1; DECLARE cur1 CURSOR FOR SELECT *...

bug
sql
correctness

Support [declare error code](https://dev.mysql.com/doc/refman/8.0/en/declare-condition.html): ``` { Name: "create DECLARE HANDLERs", SetUpScript: []string{ `DROP TABLE IF EXISTS t1;`, `CREATE TABLE t1 (pk BIGINT PRIMARY KEY);`, `CREATE PROCEDURE proc_named_condition() BEGIN DECLARE a,...

enhancement
sql

A script I am running expected this to show how long it took to import the dump, but we return zero values for the times: ```sql select timediff( (select update_time...

sql
dumps
import