Maximilian Hoffman

Results 126 comments of Maximilian Hoffman

The little I know about this makes me think we apply triggers wholesale, and do not have the ability to apply a trigger to a fraction of INSERT statements depending...

@JCOR11599 another correctness bug, this specific problem is pretty edge case-y, but the part of the code base needing refactoring/more tests is a frequent source of problems.

I think my default approach for LEFT JOIN was heavy handed, left this TODO which I think applies to your example https://github.com/dolthub/go-mysql-server/blob/main/sql/func_deps.go#L647

@CaptainStabs this PR might help https://github.com/dolthub/doltpy/pull/178 @pbronez [poetry environments](https://python-poetry.org/docs/managing-environments#switching-between-environments) might make the version switching easier.

Thanks @oscarbatori , and you bring up good points @lucab. Generally we want to provide an interface that will be backwards compatible indefinitely. Pinning to MySQL and Git semantics is...

The diff coverage would probably look OK if you merged master, a one line change wouldn't have that big of an effect.

Hi @alkamid, we have a greater variety of export types since originally shipping Doltpy, including parquet. I believe the small fix below should add some types and None's back to...

Good points about tradeoffs @alkamid, and thank you for the suggestions. In our case, I think we would lean towards including one of the two dependencies in doltpy plus the...

@fedderw The next doltpy release will let you specify `read_pandas(dolt, table, asof, fmt="parquet")`. I ran a small test and it seems like the same fix should maintain zero padding for...

This is still valid, we should be opportunistically using the second index to eliminate the SORT. @jycor this is related to some prior SORT elimination, and I think this should...