tagmanager icon indicating copy to clipboard operation
tagmanager copied to clipboard

Proposal: CSS-based blink implementation

Open johnnyshields opened this issue 12 years ago • 1 comments

The current API allowes user to specify 'blinkBGColor_1' and 'blinkBGColor_2'. I think it may currently be been broken.

I propose to replace these with a new parameter 'tagBlink', which has the following allowed value types:

  • string: specifies a class to apply while blinking. defaults to 'tm-tag-blink'
  • function: call the function on the affected tag element when blink is triggered
  • null/false: do not blink

Unlike the previous implementation, when setting class string can only set one blink color rather than two. If you want two, you'll need to make a custom function.

This will include adding blink styles for each of the semantic color styles, and updating the docs.

johnnyshields avatar May 31 '13 04:05 johnnyshields

Yep, I think it's a much nicer solution.

max-favilli avatar May 31 '13 12:05 max-favilli