Max Baz

Results 721 comments of Max Baz

I suggest making both thresholds be in one unit, in minutes - it would just be simpler for users to grasp. But first of all, it's probably best to wait...

Agree that precision is not needed here, as compared to `exec_time` for instance. As an idea, maybe it is worth extracting this in a separate util function though, `spaceship::displaytime_short` or...

Don't worry about it, you did great and we have a "squash and merge" button, so you don't need to do anything. ![image](https://user-images.githubusercontent.com/1177900/35188791-366643c8-fe3d-11e7-8286-d81e7173ac1f.png) If you are going to work on...

Sorry for being late to the party, but I personally feel this should be a separate section. Reason number one: #359 proposes a completely different approach for `git_status` section, and...

Sure 🙂 I keep my dotfiles in a git repo, and all configs are symlinked from the git repo to the expected location. For example: `~/.zshrc -> ~/.dotfiles/.zshrc`. That way,...

The thing is, I want to keep some version of this config file in my dotfiles repo; mentioning a tracked file to `.gitignore` will not stop git from showing its...

`git_status` section shows you when something is not committed, have you seen it?

I wonder if the `git_commit` should be not a new section, but an extension of `git_branch`, in order to make the two pieces better work together. For example, on your...

Makes sense. If I remember correctly, currently `git_branch` section does the following: * If commit points to a local branch, show it and stop * If commit points to a...

Looking cool, and I like that the old logic remains unchanged if none of the new `SHOW` parameters are defined. I wish this fact would be a bit more clear...