Max Eisner
Max Eisner
Thank you for the feedback and helpful example code! I'll update the PR with the proposed changes as soon as I refactored the DSL PR, and will also include Unit...
Hello there! I have updated the PR to reflect the changes made in the DSL PR, and also included some other fixes. I have also added another Cop to combine...
> Can the tests be moved to their own file in `test/rubocops/lines/generate_completions_spec.rb`? Sure, done!
I have now extended the tests. 😄 Now that https://github.com/Homebrew/homebrew-core/pull/105707 is also merged, this should be good to go if CI passes 🎉
Yeah, I'm gonna need some help with that CI error... I feel like I am missing a `return unless` somewhere? ``` 2022-09-05T17:58:39.3127476Z [31mAn error occurred while FormulaAudit/GenerateCompletionsDSL cop was inspecting...
Also, the cask audit test failures should be unrelated.
Or: should we simply scope this cop to the core tap? The run for all core formulae was fine.
Yay, all green now! (except for the unrelated tests) Thanks again! That should be everything now for the new DSL 🎉
> Failures likely fixed by #13813. Curiously, they are still present in the latest CI run 🧐 Do I need to rebase?
I have updated the previously changed formulae with the updated DSL and RuboCop. As soon as both are finalized, I will work on also adding all non autocorrectable formulae to...