kakoune icon indicating copy to clipboard operation
kakoune copied to clipboard

build: switch to POSIX make

Open svmhdvn opened this issue 1 year ago • 4 comments

This change rewrites the main Makefile to use strictly POSIX make supported features. The main changes are:

  • Use macro expansion as a means for portable conditional statements across all make implementations
  • Use the POSIX accepted (and widely implemented across all make implementations) != shell command syntax
  • Use POSIX compatible flags on shell commands

Tested on linux, freebsd, and macos using system provided make, CXX=g++, and CXX=clang++.

svmhdvn avatar Nov 06 '23 02:11 svmhdvn

Not sure why CI is failing on macos. I have tested independently with a friend's help on macos and it builds successfully. Also tested locally on both linux and freebsd, works fine.

svmhdvn avatar Jan 12 '24 15:01 svmhdvn

Pushed v2, this further cleans up the use of non-POSIX tools like install for simple POSIX equivalents. I may need to do one more iteration on this work, but it seems to be working for me locally.

Could you also figure out how to fix the CI pipeline so that these checks aren't failing based on monthly compute credits? Is there another provider you could use?

svmhdvn avatar Jan 17 '24 15:01 svmhdvn

Any plans regarding the few inline comments ?

mawww avatar Feb 10 '24 11:02 mawww

Just pushed a version with a couple fixes that I missed. Are there any outstanding inline comments now? I think I've resolved them all.

svmhdvn avatar Feb 10 '24 17:02 svmhdvn

Last missing thing is a copyright waiver commit, could you add that ?

mawww avatar Feb 27 '24 22:02 mawww

Done.

svmhdvn avatar Feb 27 '24 22:02 svmhdvn

Thanks !

mawww avatar Feb 29 '24 09:02 mawww