kakoune icon indicating copy to clipboard operation
kakoune copied to clipboard

rc ruby: Run ruby-trim-indent on mode change

Open kayhide opened this issue 4 years ago • 6 comments

As seen in other languages, run *-trim-indent when getting out of insert mode.

kayhide avatar Feb 19 '21 04:02 kayhide

Hello

I am very late in reviewing this, sorry about that, it seems to break the do-keyword test in indent/ruby can you check that and either update the test or the indent logic ?

mawww avatar Apr 18 '21 07:04 mawww

Sure, I will take a look.

kayhide avatar Apr 20 '21 00:04 kayhide

@mawww Hi, I have updated the test, pushed it. The test itself looked working, but some of CI tests failed. https://cirrus-ci.com/build/5797598868013056

Then I rebased this branch onto the current master, CI still fails. https://cirrus-ci.com/build/5841857264484352

At least, linux tests are passing. Does this look good?

kayhide avatar Apr 20 '21 00:04 kayhide

That's a bug in master, you can cherry-pick 272b702 from #4156 to make the CI pass

krobelus avatar Apr 20 '21 06:04 krobelus

@krobelus Okay, I will try it, thanks.

kayhide avatar Apr 21 '21 11:04 kayhide

@mawww Hi, it seems this PR is ready to get merged.

Or am I still expected to do something?

kayhide avatar Nov 01 '21 02:11 kayhide