mavo icon indicating copy to clipboard operation
mavo copied to clipboard

Support multiple collections for add function

Open mohammadKhalafi opened this issue 2 years ago • 3 comments

issue : https://github.com/mavoweb/mavo/issues/829

mohammadKhalafi avatar Jan 12 '23 23:01 mohammadKhalafi

Hi there, thank you so much! Maybe it's that I've just woken up, but i found it hard to follow the logic. Some comments would help, especially around L106-113

Hi! a few comments is added.

mohammadKhalafi avatar Jan 13 '23 20:01 mohammadKhalafi

Thanks! At a quick glance it looks alright, though I haven't tested it or done a deep dive.

@DmitrySharabin could you take a look as well? Note this question I raised in the original issue:

One question is: What do we do when some items in an array belong to collections and others do not? Do you add to those collections, or do you give up altogether?

LeaVerou avatar Jan 14 '23 13:01 LeaVerou

Hey there,

Sorry for the delay. I played a bit with the suggested changes. And it looks like the generated Add <collection> buttons (framed in the screenshot) stopped working.

image

@mohammadKhalafi You may find these tests useful for debugging: https://test.mavo.io/actions.html#add. And could you please provide a test case on Codepen so it is obvious how the new feature will work?

DmitrySharabin avatar Feb 14 '23 15:02 DmitrySharabin