Change raw string to tr

[bols-blue]

please show #9995

[booo]

Please try to describe why the change from raw string to QObject::tr is necessary and add it to your commit message. Thanks.

[bols-blue]

@booo Thank you for comment. I tried to rewrite it, but how about it?

[bols-blue]

I have a question. Is it better to include translation resources in a pull request?

[booo]

Thanks.

If you want to add a translation or improve one please use https://crowdin.com/project/qgroundcontrol

We are still working on the documentation: https://github.com/mavlink/qgroundcontrol/issues/9962

[DonLakeFlyer]

Why can't these all be tr instead of QObject::tr?

[bols-blue]

I used QObject::tr because it was displayed ”tr not defined.” when I check it now, it seems that Unitsetting::tr is used as tr, so I fixed it.

[muramura]

@bols-blue san I am no longer detectable by QT's LUPDATE with the current support. Is there a statement in the LUPDATE of your QT?

[bols-blue]

@muramura san I know that. Perhaps the linguist is not evaluating the macro correctly. I was looking for a setting. Priority is given to undoing and closing.

[muramura]

This statement "tr("Weight units")" is assigned to the UnitsSettings class. I thought that the others could be assigned to the UnitsSettings class as well. I used this specification to display in the LUPDATE. I also set the translation settings to display the unit settings in Japanese.

[DonLakeFlyer]

I used QObject::tr because it was displayed ”tr not defined.” when I check it now, it seems that Unitsetting::tr is used as tr, so I fixed it.

I'm a bit confused as to where this currently stands. I tried doing a compile just using tr("...") and it compiled fine for me. Are you saying that isn't the problem. The problem is that lupdate doesn't find the strings and output the correctly updated .ts files? If so does this latest change bot compile and work with lupdate?

[mrpollo]

is this PR ready to come in? I can't tell by the discussion, and the changeset looks good to me

[booo]

I think it's ready.

[muramura]

I am saying that this PR change was not discovered by the ludate command. I am hoping the change will be found in the lupdate command.

[bols-blue]

"tr" cannot be lupdated. So "QObject::tr" is used in this PR. I would like you to change "QObject::tr" to "tr" in another issue and merge it.