mavlink
Fix GStreamer package for macos
Are all OS on 18.3 or just OSX? These should be consistent. Also I don't want to reference third party locations. If you give me all the files I can upload to S3.
Are all OS on 18.3 or just OSX? These should be consistent. Also I don't want to reference third party locations. If you give me all the files I can upload to S3.
Yep, I'll move to 1.18.1 after I get it working, I believe that I have figure out how to create the tar files with @rpath configuration for the dlls. I'll write a script for us that will create such files without human intervention, and document all the process
I believe that I have figure out how to create the tar files with @rpath configuration for the dlls.
Isn't that https://github.com/mavlink/qgroundcontrol/blob/master/tools/prepare_gstreamer_framework.sh?
I believe that I have figure out how to create the tar files with @rpath configuration for the dlls.
Isn't that https://github.com/mavlink/qgroundcontrol/blob/master/tools/prepare_gstreamer_framework.sh?
This is done to configure the libraries for the dmg after it gets the QGC binary done.
I'm working with the gstreamer installation based in a specific version (since we don't use official gstreamer installation binaries), for that is necessary to remove the rpath with a fixed path, from what I understood after studying the previous zip folder for older QGC .dmg files. This is done with the helper of https://github.com/mavlink/qgroundcontrol/blob/master/tools/osxrelocator.py
That is all Gus's stuff. You could try getting a hold of him if you need help.
@dogmaphobic do you remember something about it ? can you point how to create the .tar for gstreamer CI ?
osxrelocator is used at build time not when creating the package for S3. As far as I always understood the S3 package is just the framework zipped up with no changes.
You could also try pinging Gus on slack he might see it there more quickly.
osxrelocator is used at build time not when creating the package for S3. As far as I always understood the S3 package is just the framework zipped up with no changes.
Is a post link step, after the build is done when macdeployqt finishes, it's used to remap gstreamer libraries to create the dmg file.
You could also try pinging Gus on slack he might see it there more quickly.
I'll get in touch with him, meanwhile I'm trying to remove the necessity of the tar.gz file and use the gstreamer .pkg directly.
I'm trying to remove the necessity of the tar.gz file and use the gstreamer .pkg directly.
That's just to save build time from the download.
I'm not sure who changed that. I think it used to be .pkg directly since those older packages are still up on S3. So tar may be recent.
@patrickelectric This has been verified as working. Can you give me a 1.18.1 version of GST tarball and I can put it up on S3 for you.
@DonLakeFlyer, can you try this one: https://s3.us-east-1.amazonaws.com/downloads.bluerobotics.com/QGC/dependencies/gstreamer-osx-1.18.1.tar.bz2 ?
It's uploaded to S3. Both travis and github actions will need to be updated.
@patrickelectric Can you get this into master and Stable and then I can trigger a new Stable.
It's uploaded to S3. Both travis and github actions will need to be updated.
Can you provide the URL ?
https://qgroundcontrol.s3.us-west-2.amazonaws.com/dependencies/gstreamer-osx-1.18.1.tar.bz2
I did some tests this morning and it appears to be not working. I believe that some work is necessary in the post link part to fiz the relative reference.
On Mon, Jul 19, 2021, 1:12 PM Don Gagne @.***> wrote:
I posted the new 1.18.3 version to S3 and fixed up the links.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mavlink/qgroundcontrol/pull/9541#issuecomment-882716595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJIYCNO3OPAWWFJ6J637H3TYRMJVANCNFSM4ZMTCA6Q .
@patrickelectric can you make a macos build for gstreamer-1.20.0? It is required for #10153
Looks like gstreamer now provides macos downloads:https://gstreamer.freedesktop.org/download/#macos we may not need this afterall.
The current build artefacts for MacOS from CI are not working with respect to video streaming. I have prepared and tested PR #10396 for this. I reuse the patches from this PR here from @patrickelectric but everything is updated from 1.18.1 to 1.18.6. I use the official gstreamer package.
The proposed change is superseded by https://github.com/mavlink/qgroundcontrol/commit/984e9f23795bc19d81ddb948d4f130c58782c8ec as far as I can see. Closing this therefore. Please reopen or create another PR/issue if there is still stuff to do.
