mavlink
Use number dashes for invalid value placeholders
Use number dashes for invalid value placeholders
Description
Replaced hyphens with number/en dashes in Fact::invalidValueString, as well as in all invalid-value placeholder strings. Also changed instances of 2 hyphens into a single en dash. En dashes are visually wider and more uniform with numeric characters, improving readability and preventing confusion with minus signs.
Checklist:
- [X] Review Contribution Guidelines.
- [x] Review Code of Conduct.
- [X] I have tested my changes.
Related Issue
#13698
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
By the way, I've also tried using em dashes for the non-numeric types as well as the integer part of numeric types (basically the places where we are currently using 2 hyphens), and it doesn't look too bad at all:
I don't think this looks better. I like the existing look better.
That's fair. You mean the em dashes, or using number dashes in general? That last screenshot is with the further change to em dashes, this PR just does the switch to number dashes. You can see how this one looks in the screenshot in issue #13698.
I can merge once conflicts are fixed and you've figure out what's going on with the missing vertical/ground speed thing.
I can merge once conflicts are fixed and you've figure out what's going on with the missing vertical/ground speed thing.
I've rebased this, but I can't replicate the vertical/ground speed stuff, it works as expected on my end everytime I launch a new instance with default settings.
By the way, something's up with the CI, seems like it's getting a captcha on the GStreamer download step.
By the way, something's up with the CI, seems like it's getting a captcha on the GStreamer download step.
Fixed