bufferIndex variable in mavlink_frame_char_buffer() superflous

[olliw42]

in the function mavlink_frame_char_buffer() in mavlink_helpers.h a variable bufferIndex is used, which appears to have no function, and thus should be removed IMHO.

MAVLINK_HELPER uint8_t mavlink_frame_char_buffer(mavlink_message_t* rxmsg,
mavlink_status_t* status,
uint8_t c,
mavlink_message_t* r_message,
mavlink_status_t* r_mavlink_status)
{
...
int bufferIndex = 0;
...
bufferIndex++;
...
}

It would be inconsistent to define it as int given that everywhere else uintXX is used anyhow.

I'm sorry to not do a PR, but this file isn't present in the repo, but generated, and I have no idea about that part.

EDIT: ah, maybe for this function/file it would be simple since it's just copied over 1to1 from pymavlink/generator/C/include_v2.0/, right?

[hamishwillee]

Thanks. I think you're right.

I'm sorry to not do a PR, but this file isn't present in the repo, but generated, and I have no idea about that part.

The code is imported as a submodule from https://github.com/ArduPilot/pymavlink - the correct place to make the change is in this file in that repo: https://github.com/ArduPilot/pymavlink/blob/master/generator/C/include_v2.0/mavlink_helpers.h It would be great if you could do that, but if not, let me know and I'll take care of it.

[amilcarlucas]

This should be instead reported upstream at https://github.com/ArduPilot/pymavlink

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.