MAVSDK icon indicating copy to clipboard operation
MAVSDK copied to clipboard

Fix manual control inverted r (yaw) axis

Open RoseBeaupreARA opened this issue 6 months ago • 3 comments

Protobuf message definition is defined as positive +CW, -CCW: https://github.com/mavlink/MAVSDK-Proto/blob/main/protos/manual_control/manual_control.proto#L50

MAVLink message is defined as +CCW, -CW: https://mavlink.io/en/messages/common.html#MANUAL_CONTROL

Therefore, to respect both specifications, sign must be reversed.

RoseBeaupreARA avatar May 06 '25 23:05 RoseBeaupreARA

@julianoes FWIW reminder the spec is a bit broken in respect to this message, so even if this is correct (I have not looked at it) we might have to ignore the spec. See https://github.com/mavlink/mavlink/pull/1922#issuecomment-2824145685

hamishwillee avatar May 06 '25 23:05 hamishwillee

Oh dear. You're right. However, I don't think I can change the API without a major version increase, as it would be a breaking and very surprising change!

I think we will have to rename the fields to how they are actually used in reality and then merge that before v4. That way it breaks the build and is very clearly a change.

julianoes avatar May 07 '25 00:05 julianoes