MAVSDK icon indicating copy to clipboard operation
MAVSDK copied to clipboard

Example Fly mission uses hard-coding of mission points

Open shakthi-prashanth-m opened this issue 8 years ago • 7 comments

Fly mission example uses hard-coding of waypoints. It is hard for someone to compute longitude, latitude, etc and use this example. I prefer, we can make this example take QGC Mission plan as input; where one can plan missions using QGC and feed its path via command-line to this example.

image

We can parse QGC mission plan and pass mission items to DroneCore Mission plugin. Make sense ?

Regards, Shakthi

shakthi-prashanth-m avatar Oct 19 '17 09:10 shakthi-prashanth-m

Thanks for the issue. This has been requested several times actually and it would be a good thing to have.

The only catch is that not all mission items are currently supported in DroneCore, so we won't be fully compatible. We would have to just ignore unsupported items and warn the user about it.

julianoes avatar Oct 19 '17 15:10 julianoes

@julianoes @shakthi-prashanth-m

Fly mission example uses hard-coding of waypoints. It is hard for someone to compute longitude, latitude, etc and use this example.

The solution to this problem is NED based mission points - as per #100. I really think it makes sense to implement this ourselves, sooner rather than later.

The only catch is that not all mission items are currently supported in DroneCore, so we won't be fully compatible. We would have to just ignore unsupported items and warn the user about it.

My take on this is that mission import should completely bypass whatever we do with the API. It would be something to add flexibility over the top of our existing API. So perhaps:

  • Allow upload and download of files or strings in generic waypoint format. Users can then dynamically construct the messages if they want.
  • Provide an API to send a generic waypoint message or custom message - so the user can send whatever message they like.

Yes I know it removes some of the "clean-ness" of the API, but if we don't do this then I personally as a user would be forced to write my own plugin to do this.

hamishwillee avatar Oct 19 '17 22:10 hamishwillee

#235

shakthi-prashanth-m avatar Feb 11 '18 02:02 shakthi-prashanth-m

@shakthi-prashanth-m So what does https://github.com/dronecore/DroneCore/issues/121#issuecomment-364714307 add to this discussion?

I still think we should implement #100

hamishwillee avatar Feb 11 '18 22:02 hamishwillee

@shakthi-prashanth-m So what does #121 (comment) add to this discussion?

@hamishwillee, sorry which comment ? The link you referred says that you opened this on Oct 20, 2017! :-)

I still think we should implement #100

Yeah, I think this is useful too. So I added my question regarding NED mission for my understanding.

shakthi-prashanth-m avatar Feb 12 '18 06:02 shakthi-prashanth-m

@shakthi-prashanth-m I was asking about why you added #235 to this discussion. I've responded re NED missions.

hamishwillee avatar Feb 12 '18 23:02 hamishwillee

Yeah, because this issue was about complexity of user's effort in uploading mission with hard-coding waypoint alt, lon. As #235 deals this indirectly, I referenced it.

shakthi-prashanth-m avatar Feb 14 '18 09:02 shakthi-prashanth-m