Matthew Avaylon
Matthew Avaylon
TODO: - [ ] Update `get_data_shape` to return shape unless the new bool parameter for maxshape is True. - [ ] Ensure that a dataset of references supports being expanded....
@rly I am thinking about the problem for shapes defined in the schema. How are these allowed to be written? By setting maxshape right at the end in dset, I...
I think if on write we use the shape from the schema, this should leave read alone.
> I think shape is validated before write in the docval of __init__ of the particular container class. If there is a custom container class, then the shape validation in...
Note: This could be done by next release if backwards compatibility does not raise an issue. Otherwise it will be Future (the current set milestone).
Hi @penguinpee I will discuss with the team. That being said the error does not appear on our scheduled test workflows as we are using pytest 7.4.3.
Hi @penguinpee after discussion with the team, we will update to pytest 8 in the future. I will post a deadline here when we have one.
Wonderful. Let's see!
The change to a shallow copy should be fine. The only reason I would suspect a deepcopy is needed is if we wanted to modify an independent copy. We do...
> > The only reason I would suspect a deepcopy is needed is if we wanted to modify an independent copy. > > I think this will require careful testing....