Matthias Wild
Matthias Wild
@lstein first question would be if you already have been thinking about a Linter, f.E. Flake8?
> The motivation for this was seeing errors like `hfFolder` or `zipfolder not defined`: those are the types of things that pyflakes is very effective at catching quickly. If I...
What should also be taken into consideration: When implemention a action like this, there should also be a pre-commit-hook which prevents pushing changes that would validate configured rules.
To be honest: I never integrated a linter in a already grown project, always used them from the beginning, so it is hard to give you good advices. And after...
I don't feel blamed in any way and I also don't think that @lstein does 😅 But imho this topic really needs some more discussion instead of just set it...
When this is enabled and at a point where no errors are detected, we should consider to enable pre-commit hooks, to prevent pushing if checks already fail localy.
> (question about the empty `installer/create_installer.sh` still remains though) This is really strange, since it is only empty when viewed in this PR, but when I check out the PR...
> I was intrigued by the Docker support and decided to try it. When it comes to containers, I always prefer [Podman](https://podman.io/) running "rootless" rather than Docker running as root,...
> Does runpod use podman or [docker](https://docs.runpod.io/serverless-ai/custom-apis/worker-image-creation)? > > I can try to pull the full image from docker hub and see what happens. The build issues at least should...
I already addressed a lot of changes (see the 11 unresolved conversations) and made clear that I would not want to remove the caching 😅