signal icon indicating copy to clipboard operation
signal copied to clipboard

Add displayname_template setting for group chats too

Open blastrock opened this issue 1 year ago • 3 comments

Hello,

There currently is a displayname_template for direct chats that allows adding the suffix " (Signal)" to those chats. I'd like to have the same settings for group chats, I couldn't find anything similar.

I have the same issue with the WhatsApp bridge, should I open an issue there as well, or is something that can be implemented for all bridges at once somehow?

blastrock avatar Mar 26 '23 19:03 blastrock

There used to be PR #23 which was never merged. I commented my concerns on that PR, maybe you want to have a read. In short: I think this will cause multiple problems and would be difficult to get right.

maltee1 avatar Mar 26 '23 20:03 maltee1

That's a fair concern I didn't think about! A groupname_template might be very difficult to get right indeed.

Maybe this should just be a groupname_suffix? If the name is edited from Matrix, and it ends with groupname_suffix, we strip it before forwarding the event to Signal. Could this work?

blastrock avatar Mar 27 '23 10:03 blastrock

I suppose that could work, if the user knows what they are doing.

maltee1 avatar Mar 27 '23 11:03 maltee1