signal icon indicating copy to clipboard operation
signal copied to clipboard

Editing message from Matrix resends message without explanation to Signal chat

Open jakecoppinger opened this issue 3 years ago • 6 comments

When editing a message on the Matrix side, the bridge re-sends a message into the Signal chat.

If this message was prefixed with something like "{user} edited their message to:" it would be less confusing for Signal users.

jakecoppinger avatar Oct 12 '21 23:10 jakecoppinger

Ideally, the mautrix/signal bot would delete the previous Signal message instead of adding text to the newly edited message.

Currently the bot can already delete a Signal message when the message is deleted from the Matrix room, so it should be able to delete the previous message on edition too :slightly_smiling_face:

paulRbr avatar Nov 02 '21 11:11 paulRbr

Ideally, the mautrix/signal bot would delete the previous Signal message instead of adding test to the newly edited message.

I don't see this as ideal.. as Signal keep showing deleted message as : 🗑️ Deleted message, this could leave a lot of these on successive edits..

I would prefer @jakecoppinger solution, maybe with a warning msg on matrix side to remind the poster that edits are sent in multiple messages, so he should try to limit edits

bew avatar Nov 02 '21 13:11 bew

I don't know, imagine I edit this message three times.


I'd rather see (on Signal side) this:

deleted message

deleted message

I don't know, imagine I edit this message three times.


Than this:

I don't know, imgaine I edti this message three times.

Paulrbr edited their message to: I don't know, imgaine I edit this message three times.

Paulrbr edited their message to: I don't know, imagine I edit this message three times.

Wouldn't you?

paulRbr avatar Nov 02 '21 14:11 paulRbr

Hmmm yeah maybe ok, you're right..

bew avatar Nov 02 '21 15:11 bew

In my signal the edited message is just appended and the original one stays. Might be better to delete the original message

a22sc avatar May 12 '22 17:05 a22sc

And/or prefix with * or something? I mean there's plenty ways to skin the cat where "upstream" doesn't support edits...

olmari avatar May 12 '22 17:05 olmari

I'd like to bring this topic up again as Signal received native message editing support a few weeks ago: https://community.signalusers.org/t/edit-sent-messages/975/650

This would basically make this bug a new feature request.

I assume signald would need to be extended before we can have it in this bridge here, right?

sibbl avatar Oct 19 '23 14:10 sibbl

@sibbl as now "this" current mautrix-signal (and also related signald) is basically EOL:ed and new one written in go is coming fast, this issue might be obsolete in itself, at least for legacy version it is no-go.

olmari avatar Oct 21 '23 22:10 olmari

@sibbl as now "this" current mautrix-signal (and also related signald) is basically EOL:ed and new one written in go is coming fast, this issue might be obsolete in itself, at least for legacy version it is no-go.

Unfortunately this is not an outdated issue. But it seems related to Signal's management of edited messages supported "Only by recent version of the client"

https://signal.org/blog/new-features-fall-2023/#:~:text=Edit%20messeage%20message&text=If%20you're%20using%20Signal,it%2C%20and%20make%20your%20adjustments.

The result turns "funny" anyhow:

Account A, Signal view: image

Account A, Matrix view: image

Account B, Matrix view 1: image

Account B, Matrix view 2: image

pm-McFly avatar Dec 21 '23 09:12 pm-McFly