added support for personal spaces

[eyJhb]

I've added basic support for spaces, the same way that other bridges has gotten support for spaces here.

Used the following for reference

• https://github.com/beeper/linkedin/commit/e62020dcf219f3371f608ceb9d8e5d4acd47f505
• https://github.com/beeper/linkedin/commit/3d4afcd24b9fb9f87cd722e50a3a6d873dccc10d
• https://github.com/mautrix/signal/compare/master...Jaffex:signal:add/spaceGeneration

It should be pretty much 1:1 with the beeper/linkedin implementation, except for naming the space variable space_room following notification_room convention, instead of doing space_mxid.

Hoping someone can use this! Unsure how likely it is that it will be merged :)

[WowSuchRicky]

@sumnerevans is this PR still viable and does the team have interest in the feature? If it's stale at this point I would be happy to try and assist with any conflicts; just wanted to touch base first and make sure that it is something the team actually wants in the codebase. I've personally been eager for this one.

Thanks!

[eyJhb]

I hope it would have been merged, once the initial issues was solved. I've been running this ever since I made the PR. It has been working quite well.

There might be some cases where a user is not added to the space, but I can't quite remember if it's still a thing, or what circumstances it happened under.

[eyJhb]

Fixed merge conflict :)

[WowSuchRicky]

Thanks for the hard work @eyJhb, I'm poking a few folks in the matrix room for this project to see if we can get it landed. Would love to have this and not manually move each room myself.

[razinares]

Why this has not been merged yet? or is this project dead?

[eyJhb]

Why this has not been merged yet? or is this project dead?

Most likely the maintainers are busy with other things. It can still be used fine however :) Just keep in mind, if any other PRs are merged, that does changes to the database, then it'll most likely mean trouble updating in the future (once this gets merged).

I've been running it for some time, with the below overlay in NixOS, if anyone can use it :)

{ pkgs, ... }: {
  nixpkgs.overlays = [
    (self: super: {
      mautrix-facebook = super.mautrix-facebook.overrideAttrs (old: rec {
        src = self.fetchFromGitHub {
          owner = "mautrix";
          repo = "facebook";
          rev = "86a97638c651537fac4e62acced335d597b51f9f";
          sha256 = "sha256-2S1q0Jj+n5JWxE7s+nq79yZ/1dTuKZLq/GBB3YHMyw4=";
        };

        patches = [
          (pkgs.fetchpatch {
              url = "https://github.com/mautrix/facebook/pull/291.patch";
              sha256 = "sha256-W8c8yHl15erDN+m+6TcOouO0Ah+K9vLMRfV9RnPLoVQ=";
          })
        ];
      });
    })
  ];
}

[WowSuchRicky]

Why this has not been merged yet? or is this project dead?

seems so - does anyone want to own a fork? I asked in the Matrix chat and a maintainer claimed that since Beeper does not care about spaces, getting this merged in will not be prioritized. I believe that means it is time for a fork.

[james-choncholas]

I also would love to see this merged. I've been sponsoring tulir for a few months now -- @sumnerevans is it possible to reassign the PR reviewer to tulir so they can take a look if they are available? It would be nice to avoid forking over a ~100 line feature which already exists in the other bridges.

[eyJhb]

mautrix-facebook will be replaced by https://github.com/mautrix/meta according to #332. The new meta bridge has support for spaces, which makes this PR irrelevant :)

I'm keeping this open until I switch to the meta bridge myself, but any maintainer, feel free to close this as you seem fit :)

EDIT: This also explains why the PR hasn't been merged I think, and it makes sense as well.