docker-mautic icon indicating copy to clipboard operation
docker-mautic copied to clipboard
verified publisher icon mautic

Make docker image aware for docker secrets

Open FSeidinger-XI opened this issue 1 year ago • 10 comments

Currently the mautic docker image does not support to read the db password from a file.

This would be most useful to deliver the password as a secret from docker.

If using docker secrets the secret gets mounted as a file under /run/secrets/

MariaDB already support this via the *FILE extension to the environment variable

FSeidinger-XI avatar Dec 30 '24 18:12 FSeidinger-XI

I've submitted the pull request #307 to address this issue.

FSeidinger-XI avatar Jan 04 '25 23:01 FSeidinger-XI

The PR also comes with improvements on quality of the startup process.

  1. Check that volumes are present and writeable by the docker user and group.
  2. Read the password from the MAUTIC_DB_PASSWORD_FILE if it exists.
  3. Add tests for all changes and functionalities.

FSeidinger-XI avatar Jan 06 '25 16:01 FSeidinger-XI

This issue has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/feedback-on-the-mautic-5-docker-image-experience/34591/7

mautibot avatar Jan 06 '25 16:01 mautibot

Is anyone working on this repo? Filed this issue and a PR two weeks ago and still no response.

FSeidinger-XI avatar Jan 15 '25 07:01 FSeidinger-XI

Thank you for implementing this.

dasmedium1 avatar Jan 16 '25 21:01 dasmedium1

Thanks @FSeidinger-XI I've just responded to the thread on the forums which got somewhat sidetracked.

At present we don't have an active docker maintainer team. We've been trying to build one for some time. Let's chat in #docker on Slack if you're interested?

@dasmedium1 if you've tested this could you leave a formal review, per the steps here: https://contribute.mautic.org/contributing-to-mautic/tester#leaving-your-review explaining what you've tested so that it can be considered a positive test? Thanks in advance!

RCheesley avatar Jan 16 '25 21:01 RCheesley

Working on it.

dasmedium1 avatar Jan 22 '25 01:01 dasmedium1

Hey there! I'm helping the new maintainers of this repository. It was neglected for some time but that changes now! Could you please re-test if you are still getting this issue so we could focus our limited time on the issues that are still relevant? If there will be no response we'll close this issue in 1 week. It can always be re-opened later on.

IonutOjicaDE avatar Apr 15 '25 16:04 IonutOjicaDE

Hello,

As this is an feature request, it might take some time until we can get to this issue.

As it's a security feature, it should be one of the 1st ones implemented, though!

cibero42 avatar Apr 23 '25 10:04 cibero42

Hello @FSeidinger-XI

Can you check if this PR does fit your needs?

https://github.com/mautic/mautic/pull/14542#event-17454060778

Thanks

henmohr avatar Apr 29 '25 18:04 henmohr