docker-mautic icon indicating copy to clipboard operation
docker-mautic copied to clipboard

Remove unused dependencies

Open J0WI opened this issue 5 years ago • 3 comments

This PR remove unused dependencies, namely:

  • git, sudo and zip
  • wget (replaced with curl)
  • cron and unzip (replaced with BusyBox)
  • build dependencies (*-dev)

The chmod +x statement is not needed if the executable bit is tracked with Git. I also merged parts of https://github.com/mautic/docker-mautic/pull/146, so the GD extension is already included here.

J0WI avatar Mar 28 '20 00:03 J0WI

Thanks for your Pull ..

I recommend sending a few changes by yourself, as this greatly changes the way thousands of mautic users deal with crons, etc.

git is used to make it possible to install github dependencies and plugins.

sudo is necessary to execute commands on the command line without hurting the log permissions.

luizeof avatar Mar 28 '20 17:03 luizeof

sudo is necessary to execute commands on the command line without hurting the log permissions.

sudo should be avoided in docker. You can use docker exec -u.

git is used to make it possible to install github dependencies and plugins.

The documentation doesn't motion this procedure: https://docs.mautic.org/en/plugins#install-plugins

The cron replacement may need some further testing, but I'm pretty sure that BusyBox can be used as a drop-in replacement. In general it's not recommend to run a cron daemon in a container anyway. A sidecar container or docker exec on the host are the preferred solutions.

J0WI avatar Mar 28 '20 19:03 J0WI

@J0WI yes, i am happy for the contribution. I would just like to test one thing at a time.

luizeof avatar Mar 28 '20 19:03 luizeof