api-library icon indicating copy to clipboard operation
api-library copied to clipboard

Replace setLogger with built in trait

Open moorl opened this issue 2 years ago • 1 comments

For my mautic API integration I can't use repositories in composer.

I Found a better way for backwards compatibility. Just use the built-in trait.

Kind regards moori

moorl avatar Oct 19 '23 08:10 moorl

Codecov Report

Merging #315 (7f8d623) into main (fa141f9) will increase coverage by 0.10%. The diff coverage is n/a.

:exclamation: Current head 7f8d623 differs from pull request most recent head 0578aff. Consider uploading reports for the commit 0578aff to get more accurate results

@@             Coverage Diff              @@
##               main     #315      +/-   ##
============================================
+ Coverage     52.49%   52.59%   +0.10%     
+ Complexity      390      389       -1     
============================================
  Files            30       30              
  Lines          1042     1040       -2     
============================================
  Hits            547      547              
+ Misses          495      493       -2     
Files Coverage Δ
lib/Api/Api.php 81.20% <ø> (+1.07%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 19 '23 08:10 codecov-commenter

Hi @moorl could you possibly fix the codestyle issue causing the tests to fail? Thanks!

RCheesley avatar Jul 18 '24 09:07 RCheesley

Fixed in https://github.com/mautic/api-library/pull/327

escopecz avatar Jul 19 '24 08:07 escopecz