api-library icon indicating copy to clipboard operation
api-library copied to clipboard

psr/log 3.0 compatible, php 8.0

Open christian-beckmann opened this issue 3 years ago • 1 comments

setLogger has correct implementation of LoggerAwareInterface, do to issue https://github.com/mautic/api-library/issues/273

christian-beckmann avatar Sep 15 '22 13:09 christian-beckmann

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @christian-beckmann.

cla-bot[bot] avatar Sep 15 '22 13:09 cla-bot[bot]

Hi @christian-beckmann thanks for the PR - can you please sign the Contributors Agreement linked above (you can do this online). Thanks!

RCheesley avatar Sep 26 '22 10:09 RCheesley

Take it or leave it.

christian-beckmann avatar Sep 26 '22 10:09 christian-beckmann

Thanks, we would love to accept the contribution but we can't do that without the contributors agreement being signed. That applies across all Mautic repos for all contributors.

If you prefer not to sign it we will close the PR as it won't be accepted without it.

RCheesley avatar Sep 26 '22 12:09 RCheesley

Is there a way how I can help to get this PR approved? I really need this fix for one of my projects.

Rocksheep avatar Oct 12 '22 20:10 Rocksheep

This needs 2 things to get it merged:

  1. Fix the CI checks
  2. Two approvals that it works correctly and the code has no issues.

escopecz avatar Oct 13 '22 07:10 escopecz

Another issue with this PR that I've missed is that the author do not want to sign CLA, so we cannot merge it into the open source project. So i'll close it and someone else must make the changes.

escopecz avatar Oct 13 '22 10:10 escopecz

What a joke lmao. Using this PR. It works fine btw, thanks.

benfavre avatar Oct 13 '22 15:10 benfavre

To use the fork, just add this to your composer.json

{
"repositories": [ { "type": "vcs", "url": "https://github.com/Rocksheep/api-library.git" } ], 
"require": { "mautic/api-library": "dev-upgrade-to-php8", }
}

christian-beckmann avatar Feb 10 '23 14:02 christian-beckmann

@christian-beckmann can you sign the Contributor License Agreement please?

PierreAmmeloot avatar Apr 12 '23 13:04 PierreAmmeloot