dirsearch icon indicating copy to clipboard operation
dirsearch copied to clipboard

1341 Issue fix - reports folder is created (empty) when you specify output flag

Open ajcriado opened this issue 6 months ago • 2 comments

Description

The reports folder is always created where you execute the app even though you specify output flag because controller.setup method is not handling the options["output"] value, so it creates the folder ("reports" name by default, stored in options["output_path"]) leaving it empty.

I just control if options["output"] comes with value as it is done in controller.setup_reports method

Fix #1341

1

ajcriado avatar Dec 30 '23 08:12 ajcriado

Hi Antonio! Thanks for the contribution!

Seems a valid fix @shelld3v, right?

maurosoria avatar Jan 04 '24 17:01 maurosoria

This should work, but I'm seeing a very similar check here. image

I'm wondering whether we should move that piece of code (creating report folder for auto-save reports) to setup_reports? I don't even know why I didn't do it from the start, was it because of an unknown issue? 🤔

shelld3v avatar Jan 05 '24 11:01 shelld3v