background-geolocation-android
background-geolocation-android copied to clipboard
mauron85
Added kalman filter to reduce noice in geo locations
Added kalman filter for Activity provider to reduce the noice in the geolocation, this filter is configurable.
Thank you for this commit. Will review and eventually merge it. However I'm thinking about making Kalman filtering available for all providers. What do you think?
yah, we can add it to all the providers. I will add and update the pull request
Hey, @mauron85 I have added the filter to all the 3 providers, please verify.
Unfortunately there are merge conflicts. (I know nobody likes them). However it should be pretty easy to resolve them. Will you do it?
Ok thanks. I'm in process of reviewing/trying to understand the whole PR. I'll add comments as I go.
The first would be:
-
Please Move Tracker1D.java to separate package (maybe with your name or preferred namespace). First it will give you credit for you work and second it wasn't written or contributed to, by me in any way.
-
What about licensing Tracker1d.java. Is it code you've written? If not what is the source and it's license?
@mauron85 I have moved the filters to the new package, and the code is not completely written by me, I have used some open source references which has free MIT Licence.
Ok. I'll take some time to review this. Merge eventually. Thank you for your contribution.