keycloak-angular icon indicating copy to clipboard operation
keycloak-angular copied to clipboard

test(auto-refresh-token): fix loginOptions in login inactivity test

Open no-felix opened this issue 1 month ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Test-only fix

What is the current behavior?

A unit test in AutoRefreshTokenService's spec incorrectly assigns logoutOptions in the "login" inactivity timeout test, causing an expectation failure because mockKeycloak.login is invoked with undefined.

Issue Number: N/A

What is the new behavior?

Correct the test to set loginOptions: { redirectUri: 'testLoginUri' } for the "login" inactivity timeout case. The test now verifies that mockKeycloak.login is called with the expected options. No production code changes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

no-felix avatar Nov 28 '25 17:11 no-felix

Hi @no-felix, I will fix the pipeline this weekend and merge the fix. Thank you! 🙂

mauriciovigolo avatar Dec 11 '25 04:12 mauriciovigolo

@mauriciovigolo When do you think you will release v21? :)

Masmarino avatar Dec 16 '25 07:12 Masmarino