keycloak-angular icon indicating copy to clipboard operation
keycloak-angular copied to clipboard

feature: Angular v.21 update

Open ArnaudFlaesch opened this issue 1 month ago • 7 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

ArnaudFlaesch avatar Nov 21 '25 16:11 ArnaudFlaesch

Thanks for the approval, there's still one test failing, I don't know why exactly. Might be worth it to replace Karma with Vitest as Karma is deprecated and Angular 21 has native support for Vitest.

ArnaudFlaesch avatar Nov 24 '25 14:11 ArnaudFlaesch

The Test also fails on the current master Branch.

Would probably be smarter to just merge these Changes and then maybe switch to vitest in another PR.

AdrisGithub avatar Nov 28 '25 09:11 AdrisGithub

It will be cool to merge quickly this PR if tests also fails on main branch yes.

Masmarino avatar Nov 28 '25 10:11 Masmarino

@AdrisGithub #685

no-felix avatar Nov 28 '25 17:11 no-felix

@mauriciovigolo Hi, is it possible for you to review this PR (and the other one mentioned above) and possibly make a release afterwards please ?

ArnaudFlaesch avatar Nov 30 '25 19:11 ArnaudFlaesch

Hi @ArnaudFlaesch, sorry I will dedicate some time for this PR this weekend. Thank you for your work! 🎉

mauriciovigolo avatar Dec 11 '25 04:12 mauriciovigolo

Great work, @ArnaudFlaesch! 💯

Thanks :)

ArnaudFlaesch avatar Dec 15 '25 09:12 ArnaudFlaesch

The failing CI (npm ci) looks due to an out-of-sync package-lock.json.

Marcio9200 avatar Dec 17 '25 14:12 Marcio9200

The failing CI (npm ci) looks due to an out-of-sync package-lock.json.

https://github.com/mauriciovigolo/keycloak-angular/pull/680#discussion_r2618266348

mauriciovigolo avatar Dec 18 '25 05:12 mauriciovigolo

I will release the new version until Sunday, I updated the v21.0.0 milestone. Thanks!

mauriciovigolo avatar Dec 18 '25 05:12 mauriciovigolo