keycloak-angular icon indicating copy to clipboard operation
keycloak-angular copied to clipboard

feat: Add support for keycloak-js@26

Open tomaThomas opened this issue 1 year ago • 5 comments
trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes #583

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Support for UMD distribution was removed from keycloak-js, which makes it necessary to update the moduleResolution

tomaThomas avatar Oct 12 '24 11:10 tomaThomas

Have you actually tried this? I published my own version and had an error with the Keycloak namespace. I believe you have to replace the Keycloak.* types with imported types. What I ended up doing is replacing the types with any because that didn't work either but turns out it was always installing an old version from the cache so I don't know whether using imported types will work or not.

JonasDev17 avatar Oct 16 '24 09:10 JonasDev17

Have you actually tried this? I published my own version and had an error with the Keycloak namespace. I believe you have to replace the Keycloak.* types with imported types. What I ended up doing is replacing the types with any because that didn't work either but turns out it was always installing an old version from the cache so I don't know whether using imported types will work or not.

What's your moduleResolution? Could be related to Support for UMD distribution was removed from keycloak-js, so node module resolution does not work anymore

tomaThomas avatar Oct 16 '24 09:10 tomaThomas

Have you actually tried this? I published my own version and had an error with the Keycloak namespace. I believe you have to replace the Keycloak.* types with imported types. What I ended up doing is replacing the types with any because that didn't work either but turns out it was always installing an old version from the cache so I don't know whether using imported types will work or not.

What's your moduleResolution? Could be related to Support for UMD distribution was removed from keycloak-js, so node module resolution does not work anymore

I copied your code, built and published it, so it is bundler.

JonasDev17 avatar Oct 16 '24 09:10 JonasDev17

Have you actually tried this?

The example in this repo is working, and I tried my own application now. With moduleResolution bundler (in my application) it is working

tomaThomas avatar Oct 23 '24 12:10 tomaThomas

Have you actually tried this?

The example in this repo is working, and I tried my own application now. With moduleResolution bundler (in my application) it is working

Ahh misunderstanding, in my project I had mine set to node. That's why it didn't work in my case.

JonasDev17 avatar Oct 23 '24 12:10 JonasDev17