repodriller icon indicating copy to clipboard operation
repodriller copied to clipboard

if it's a merge, provide both parents of the commit

Open mauricioaniche opened this issue 8 years ago • 6 comments

mauricioaniche avatar Nov 03 '16 14:11 mauricioaniche

Working on this as part of #100

davisjam avatar Oct 24 '17 17:10 davisjam

Any news about this feature? :)

ttben avatar Dec 16 '17 10:12 ttben

Not from me. Do you wanna work on it, @ttben ? Let me know and we can discuss the implementation!

mauricioaniche avatar Dec 16 '17 14:12 mauricioaniche

I can't implement it for now, as I rush 2 papers.. But we can always discuss :) This way, if someone else has time, it will be quicker to implement it!

Adding this feature should:

  • not break any existing code using RepoDriller,
  • be seamless for new users,
  • provide "left" and "right" parent.

Problem: if one wants to analyse every merge commits, even with left and right fields, she has no idea the branches of left and right. For now, left and right would be String ; but I think Commit instances would be better (see #112) as it embed every usefull information.

Adding a subclass MergeCommit to Commit class will match this constraints and fill the required feature. I am clearly a newbie in this project as I just discovered it few days ago, don't hesitate to tell me if I am talking non sense!..

ttben avatar Dec 17 '17 14:12 ttben

Really clear. I'll try to tackle this issue soon!

mauricioaniche avatar Dec 17 '17 14:12 mauricioaniche

Thanks :) I think it will be a useful information!

ttben avatar Dec 17 '17 14:12 ttben