repodriller icon indicating copy to clipboard operation
repodriller copied to clipboard

GitRepository commit processing is brittle

Open davisjam opened this issue 6 years ago • 1 comments

GitRepository has these limits:

private static final int MAX_SIZE_OF_A_DIFF = 100000;
private static final int DEFAULT_MAX_NUMBER_OF_FILES_IN_A_COMMIT = 5000;

If you set these values both to 1, you will get RuntimeExceptions while building and/or processing ChangeSets.

See also #118 and #119 where I noticed this bug as reported by @AjroudRami.

davisjam avatar Jan 20 '18 18:01 davisjam

Yes, they were introduced due to crazy large commits that may exist in repos and could throw OOM errors.

The user can change the configuration if she wants to, though. What we can try to do is to be friendly and warn her if limits are too low.

mauricioaniche avatar Jan 20 '18 21:01 mauricioaniche