Maurício Aniche
Maurício Aniche
Maybe this can be configured by the user. She can choose to either halt the study or keep going! To keep compatibility, we make default to keep going.
Yes, they were introduced due to crazy large commits that may exist in repos and could throw OOM errors. The user can change the configuration if she wants to, though....
How do you see one using this feature? You are visiting commits, and you need the diff between X and X - 3, let's say? And you need to do...
Sounds good to me, then! @davisjam I meant `SCM` interface, indeed!
I'd say we should avoid exposing JGit details out of `GitRepository`; otherwise, clients would have to change when using SVN. At this moment, I'd say either returning a simple String...
List of modifications? Not sure if I understood. I thought the goal was to return the diff between version A and B!
I do not see Repodriller returning a list of `Modification` for this diff between commits feature. I'd rather model it as an _utility method_, e.g.,`List getDiffBetween(string hash1, string hash2)` or...
Sorry for the confusion, I do not know all the class names by heart. It definitely does not make sense to pass JGit's internals to outside. However, our model contains...
Go for it! Let me know when the PR is done! :)
Thanks! I'll review it soon!! :)