mauke

Same root cause. https://metacpan.org/dist/Util-Underscore/source/lib/Util/Underscore/References.pm is full of `goto &Scalar::Util::...`, the Scalar::Util functions are simply aliases for builtin ones (since 1.64), and `goto &builtin::...` is broken, which is #22542.

Shout-outs to https://github.com/Dual-Life/Scalar-List-Utils/pull/134 and https://github.com/Test-More/test-more/pull/999.

> This change is also causing test failures in `t/porting/utils.t`. That's the Test2::Hub issue I mentioned above. Once we sync the latest Test::Simple from CPAN, the error should disappear. >...

@haarg Can you show me a few examples you found? I want to see if it is possible to avoid most false positives or if I should just throw the...

> Taking a quick look at CPAN, most uses of this construct are intentionally comparing booleans, so this warning would be a false positive. I can't replicate this. I did...

I just pushed a change to get rid of a class of false positives (where `!` on the right-hand side has been constant-folded away). @haarg, do you have more examples...

There have been no new comments in a while. I still think this warning is a good idea, but to collect more feedback, I'd like to merge it into blead...

I've opened a bug ticket with two alternative suggestions for fixing the code: https://rt.cpan.org/Ticket/Display.html?id=154767 IMHO the test code in File::Tabular relies on a bug in perl (#22385). It calls `open($_[0],...

> I'm not sure I really like the change to attempt to fix #22385. Requiring a literal undef for this kind of behavior doesn't feel like how things in perl...

The main focus of this ticket, File::Tabular, is working again. Any further discussion of the semantics of `open` probably should not happen in this ticket (I believe it is being...