Matthias Wessendorf

Results 223 comments of Matthias Wessendorf

When I do it with a `KafkaChannel` (using a `host`, instead of a `path`), like: ```yaml --- apiVersion: serving.knative.dev/v1alpha1 kind: DomainMapping metadata: name: kafka-channel-one.my-cloudy-server.com namespace: default spec: ref: name: kafka-channel-one...

> We use domain mapping in konk.dev and kn quickstart https://github.com/csantanapr/knative-kind/blob/master/05-eventing-samples.sh yes, and simple things like that do work - just not broker (for the error stated in the `reason`).

> You're again referencing the Kubernetes Service. yes, as a reasonable work-around I use the actual k8s Service. and do the `path` fiddling for the different brokers on my end....

> This should probably be fixed for GA one way or the other (either by removing the "general Addressable" support, or by supporting path mappings). I'd think that allowing `path`...

No, we use `0.10.2` of the library, I think it's the last release before the refactoring you did. Here is what we basically do: https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push-sender/src/main/java/org/jboss/aerogear/unifiedpush/message/sender/apns/ApnsUtil.java#L79-L109 @pb82 Is now the new...

> what about a feature flag, off by default, so that we're backward compatible? That sounds like a good idea, I am +1 on this, @pierDipi

The reconciler should also not enforce a broker: ``` b, err := r.getBroker(et) if err != nil { if apierrs.IsNotFound(err) { logging.FromContext(ctx).Errorw("Broker does not exist", zap.Error(err)) et.Status.MarkBrokerDoesNotExist() ```

This is the newest version of the doc: * https://docs.google.com/document/d/1WhhLSJJ7GWcyidK0_78MpgRzyfjW-fkeXfo6UTudqOc/edit?resourcekey=0-q31cg7nTwdLIYXYUQqkTuw (after the other referenced got copied over to new GDrive)

/close we can close this, as we have moved a different path, and we keep the "reference" on the ET (see other issues and feature tracks here)