streem
streem copied to clipboard
Intended unlock in `kvs_update`?
Hi. I'm a researcher working on concurrent programs written in C and completely new to this project.
While reading the code, I found the following part in kvs_update
:
https://github.com/matz/streem/blob/d022e833335e490bd1dccf0e3bfff71eb50a40bd/src/kvs.c#L113-L119
After k->lock
is released in 113, it's released again in line 117. Unless strm_funcall
returns after acquiring k->lock
, line 117 would not be necessary. I don't fully understand the behavior of strm_funcall
, but I can't find such cases yet. I'm wondering whether line 117 is intentional and necessary or could be removed.
Thank you.