indigo-player
indigo-player copied to clipboard
matvp91
image height should used in the bandwidth chooser instead of image width
Describe the bug
right now the bandwidth chooser in the right bottom of the player shows the image width instead of height for the variant entries in the HLS playlist. that's rather irritating, because all other players use the image height in this place. image height is also commonly used in the video tech world eg. to refer to FHD as "1080p" etc.
I went through the code and noticed that track.width is used in the UI to display a label for each video variant. See https://github.com/matvp91/indigo-player/blob/master/src/ui/components/Settings.tsx#L58
Would you mind filling in a PR or want me to take this one?
if it would be a python or rust project, i would offer you a PR immediately, but unfortunately i'm not used to TS and all the mysteries of its build systems, although i could perhaps guess the right solution in this particular case by chance. ;)
you'll now find a proposal to fix this issue in PR #59 beside eliminating some other flaws.
btw.: i really like your software and use it frequently in my own work! e.g. https://gitlab.com/mur-at-public/live-video thanks!
@mash-graz Thank you for your kind words! It looks pretty cool to see indigo in action in that screenshot! :)