Matt Robinson

I've added this to the 1.6.0 milestone. I think we need to consider the aim of any dashboard nag message. ClassicPress will hopefully support PHP8 with version 1.5.0. Currently ClassicPress...

We may need to review these searched tickets: https://core.trac.wordpress.org/query?component=Date%2FTime&resolution=fixed&time=01%2F01%2F2018..01%2F19%2F2022&col=id&col=summary&col=type&col=milestone&order=id And I am not 100% sure on the list above, the last 3 for example seem not to be change sets...

@alvarofranz - I've had another go at creating this PR and have it passing unit tests locally. Are you happy for me to close this PR and open a new...

Closing in favour of ClassicPress/ClassicPress#1123

We should make that change if that was the WP assertion, `sanitize_key()` for the attribute name then and `esc_attr()` for the attribute name. I wonder if the function name may...

I don't really see a semantic difference between an assertion and a comment, the word assertion means to state something positively to me, so I'm not sure why the need...

> The question is whether core functions need to sanitize the attribute name at all. I would sound definitely yes. There is a filter in the code, and any nefarious...

> This sort of question has come up often at WP: should core escape translated text? They always answer no, even though translated text is filtered. The theme team nudges...

> No, I think it's mostly because it is not necessarily output at the point of translation. (escape on output, because you need context) Most core translations are seen in...

Thanks Joy, I was looking at the backport script output for 50921 as it was pulling in more changes that the upstream commit alone. We have made a start, and...