Matt Robinson
Matt Robinson
Re-opening as this is a good change to consider for CP Core
Closing in favour of #1128 where we can handle any future conflicts more easily.
PR updated and tests now passing with merge of `develop` changes. We need to decide if we include: https://core.trac.wordpress.org/changeset/52065
Two review on comment thread above, merging.
More recent commits are starting to reduce failures and errors in PHPUnit tests when run in PHP 8.0 environment. These are from the following Upstream tickets: https://core.trac.wordpress.org/ticket/50897 https://core.trac.wordpress.org/ticket/50343 https://core.trac.wordpress.org/ticket/50833 https://core.trac.wordpress.org/ticket/50913...
Still some `grunt phpunit:multisite` issues left to fix.
@bahiirwa - I suspect we will get more conflicts on merging ClassicPress/ClassicPress#1105 so it might be worth waiting until we have that merged and looking again. Do you think ClassicPress/ClassicPress#1105...
@bahiirwa - It is already added: https://github.com/ClassicPress/ClassicPress/pull/950/commits/7254316a12ddda20894401af04078e652897af01
@viktorix - That certainly looks like you need to install PHPUnit inside your WSL system. Make sue for the moment at least to get PHPUnit6 as the current code doesn't...
Please can we have a progress report on this proposal. Is there a possibility of a PR soon? 1.5.0 is nearing Release Candidate phase, without a PR soon we may...