Matt Robinson
Matt Robinson
I've managed to re-create this PR locally, backporting in order and have it passing tests locally, @bahiirwa - are you happy if I create a new PR and close this...
PR was re-created and erroneosuly pushed to `develop`, tests all pass, see commits: https://github.com/ClassicPress/ClassicPress/commit/eb449e97a40b0f7327408202b43a764d39b53178 https://github.com/ClassicPress/ClassicPress/commit/b82dcaec7f44f24de3195762e51fade54df4c723 https://github.com/ClassicPress/ClassicPress/commit/445373e1434c37af635e189fc288e27dafa793a1
> I don't have anything substantive to add, but just want to say: "Wow, @mattyrob , great work!" Thanks @KTS915 - but this is just a re-opening of a PR...
@joyously - good spot, thanks for pointing that out. I needed to revert the reversion to restore the changes in the original PR.
> We should close this for ClassicPress/ClassicPress#1116 Agreed ClassicPress/ClassicPress#116 looks cleaner to fix up.
Testing on PHP 5.6 and 7.0 is failing as WebP images are not supported - these tests should be detecting this already but for some reason, maybe our testing platform...
Further changes made today have results in the unit testing for PHP 7.0 passing now. Tests on 5.6 are failing in the GH Actions but the specific test (`test_wp_save_image_file` in...
I'm more than happy to update in this way - is that the standard we are working to?
I think I prefer the `CP-` prefix - it may help later with ensure docblocks are updated correctly with backports. Change pushed.
There is a huge amount of backporting work to be done for PHP 8 and 8.1 I may not even have all of it but this is the list I...