gelf-extensions-logging icon indicating copy to clipboard operation
gelf-extensions-logging copied to clipboard

Published 20 hours ago • verified publisher icon mattwcole

Performance of Logging Extension

Open Brunni opened this issue 1 year ago • 1 comments

As there might be really, really many log messages, it might be important to tune the extension regarding performance.

e.g. Remove the new list here: https://github.com/mattwcole/gelf-extensions-logging/blob/22ee531949f54d5da26b958e6bcdfc622c027d18/src/Gelf.Extensions.Logging/GelfLogger.cs#L113

Why use ToArray here and not ToList? https://github.com/mattwcole/gelf-extensions-logging/blob/22ee531949f54d5da26b958e6bcdfc622c027d18/src/Gelf.Extensions.Logging/GelfLogger.cs#L42

Brunni avatar Sep 09 '24 11:09 Brunni

Hi, I'm very much open to introducing performance improvements where they make sense. Any improvements would need to be quantified with benchmarks however. If that is something you are interested in working on, then please feel free to submit some PRs.

mattwcole avatar Sep 10 '24 17:09 mattwcole