jekyllthemes icon indicating copy to clipboard operation
jekyllthemes copied to clipboard

_config.yml: Remove decommissioned rdiscount

Open riouwa opened this issue 7 years ago • 5 comments

In May 2016, GitHub decommissioned rdiscount and force use of kramdown.

Closes https://github.com/mattvh/jekyllthemes/issues/494

riouwa avatar Jul 12 '17 08:07 riouwa

Hi, since we haven't seen this repository's owner for a very long time, I forked it to my repo and built this website with a new domain name: http://jekylltheme.org.

Anyone's theme who submitted it before will still be seen at http://jekylltheme.org and welcome everyone to contribute this website if you have nice themes.

Later I will beautify this repository to make it better, an excellent website needs everyone's contribution/PR too!😊

jarrekk avatar Jul 19 '17 15:07 jarrekk

Thanks for the PR! @RioSatria are You sure that doesn't break the repo? Jekyllthemes doesn't use Github Pages feature, the page is built locally on the hosting server by scripts.

gynter avatar Aug 04 '17 08:08 gynter

I've done my research and see no downside by switching to kramdown.

One thing you should note though, I'm not seeing any Gemfile on your repo. Since you are not using GitHub Pages, kramdown need to be installed manually.

riouwa avatar Aug 04 '17 09:08 riouwa

Exactly, but since I don't have access to web server (only @mattvh has), then I have no clue, if kramdown is installed or not.

gynter avatar Aug 04 '17 09:08 gynter

Somehow I don't have a gemfile for the project. I'll fix that up when I get around to upgrading everything to a modern version of Jekyll. (See #395)

mattvh avatar Aug 10 '17 02:08 mattvh