overholt icon indicating copy to clipboard operation
overholt copied to clipboard

Making overholt work with recent dependencies

Open arnuschky opened this issue 11 years ago • 8 comments

  1. update of tests
    • adjust model factories to new Factory-Boy
    • enable login system for recent Flask-Login (disabled by default for tests)
    • obtain CSRF token from login form using Flask-Fillin (old method didn't work anymore)
  2. update of forms imports for new wtf
  3. update all dependencies

arnuschky avatar Jun 10 '14 07:06 arnuschky

@arnuschky Thanks for taking the time to do this. My only criticism is that flask.ext is going to be deprecated. There's no reason to use it.

mattupstate avatar Jun 10 '14 14:06 mattupstate

@mattupstate, why you say flask.ext is going to be deprecated? I see http://flask.pocoo.org/docs/extensiondev/#extension-import-transition says it's ok.

peterdemin avatar Jun 10 '14 14:06 peterdemin

@peterdemin mitsuhiko/flask#1085

mattupstate avatar Jun 10 '14 14:06 mattupstate

Ah really? I thought it's the other way 'round. :) Will fix it tonight.

arnuschky avatar Jun 10 '14 16:06 arnuschky

I tested this, but none of the release version of the different flask extensions used by overholt seem to support this. It's a recent change, I guess we have to wait for it to trickle down. (flask-security is among them, btw)

arnuschky avatar Jun 10 '14 18:06 arnuschky

@arnuschky I'm sorry, but I'm not sure I understand. I use flask_<extension_name> in all my projects.

mattupstate avatar Jun 10 '14 18:06 mattupstate

Ah, I misunderstood, sorry. I thought that it changes to flask_ext.<extension_name>. Works now.

arnuschky avatar Jun 10 '14 18:06 arnuschky

Rebased previous commits, removed accidentally committed changes to config files.

arnuschky avatar Jun 13 '14 22:06 arnuschky