flask-social
flask-social copied to clipboard
mattupstate
Python 3.x support
~~urlparse is renamed to urllib.parse in python 3.x~~ I assume you only support 2.x versions, is there any plans for 3.x compatibility?
I start some work to add python 3.x support. If someone else do same thing please let me know, we can cooperate maybe :smile: .
Ok, if someone need py3 working version, please check my py3 branch. For now waititg for python-twitter update to new version, aslo with py3 support. Then I merge it to my development branch.
I just looked at your PR. That's a lot of changes for py3 support. I've only identified two incompatibilities (urlparse and iteritems in utils.py).
Your PR also contains a lot of whitespace fixes which have nothing to do with py3 support.
Nevertheless, I see that the PR is "closed". But I don't see the changes in the develop branch. Has it been successfully merged? Or was this change abandoned?
Ok, so whole story is I start to use this plugin in my other project. Which is in python 3. So I found bug and fix it. But then I found other bugs like broken tests, no flask factory pattern support... so I fix it and stack it in that 1.6.3.dev1 PR. By the time @mattupstate claim that this lib is no more maintained.. I ask what to do to be maintainer, but no answer. So I close PRs and now I only work on it in my forked repo.
But if you or someone will check my work and give me some feedback, I can reopen/write issues and send PM step by step again.. I just won't do something and nobody cares..