erlang-stdinout-pool icon indicating copy to clipboard operation
erlang-stdinout-pool copied to clipboard

Fix typo to match command location and C Makefile target

Open djui opened this issue 14 years ago • 3 comments

djui avatar Sep 29 '11 13:09 djui

Is this commit right? The Makefile has:

 ../priv/stdin_forcer: stdin_forcer.c
      @mkdir -p ../priv
      $(CC) -Wall -Werror -pedantic -ansi -O2 -o ../priv/stdin_forcer stdin_forcer.c

Looks like changing the loader to get_base_dir(?MODULE) ++ "/priv/stdinout_forcer" would not find stdin_forcer.

mattsta avatar Sep 29 '11 17:09 mattsta

Btw: maybe it's possible to use your project as library application, start it using application:start(stdinout) and then just use code:priv_dir(). Should make it cleaner.

djui avatar Sep 29 '11 18:09 djui

Good point about turning it into an application.

Maybe version 2.0 will be application + consistent naming + better worker pool.

mattsta avatar Sep 29 '11 18:09 mattsta