chromiumoxide icon indicating copy to clipboard operation
chromiumoxide copied to clipboard

Question: Make `ScreenshotParams` clone-able or pass by ref

Open JuxhinDB opened this issue 11 months ago • 2 comments

Have a use-case currently where I need to use the same ScreenshotParams to handle screenshots for multiple pages in different branches. As it stands, I need to re-declare the params for each branch as fn screenshot moves ScreenshotParams. Quick-fix would be to derive Clone, and alternatively we could avoid consuming the screenshot params. Wanted to get some feedback here, if so I can open a PR with the preferred approach.

Also, thank you for the great library! Using it to power some parts of Have I Been Squatted.

JuxhinDB avatar Jan 19 '25 16:01 JuxhinDB

sounds reasonable to me

mattsse avatar Jan 20 '25 12:01 mattsse

That sounds reasonable, feel free to send a PR

Sytten avatar Nov 24 '25 18:11 Sytten