Matt Sinclair

Results 48 comments of Matt Sinclair
trafficstars

> > is this waiting on us, @poal023 ? > > sorry for the delayed response, but yes, it is. I think the stats in [here](https://github.com/gem5/gem5/blob/stable/src/cpu/simple/base.cc) are added, unless I...

@mjkpolo feel free to add comments as appropriate.

@powerjg : it looks like the one failing test was cancelled -- is there a way for us to manually rerun it/all tests in Github actions?

> @mattsinc, all tests are passing now. I just re-ran the failed one last night. Great! For reference is there something @abmerop or I could have done? @abmerop feel free...

> > Great! For reference is there something @abmerop or I could have done? > > I'm not sure what access you have, so I'll provide the steps I follow,...

> FYI, I may not get to this until next week @NSurawar has changes to make from my suggestions already, so no worries.

@NSurawar can you please wrap the changes up this week?

@NSurawar : you'll also need to update this branch to the head of develop before this can be committed.

@NSurawar are you able to make @abmerop 's requested changes this weekend?

> @NSurawar are you able to make @abmerop 's requested changes this weekend? @NSurawar please let me know -- we are trying to release a new version of gem5 and...