Matt

Results 150 comments of Matt

FWIW, I've mostly solved this by just doing the following: ```py # I strongly dislike how struct is defined, IMO the attrs should be curried def struct(**attrs): return lambda value,...

A `Result` type generally has value when we think that a failure is expected (and not a bug). In this case, if the file doesn't exist in the manifest, it's...

I'd prefer not breaking here - I think providing an alternative would make sense. Alternatively, we may want to consider bringing up with the bazel team the possibility of changing...

Directory based runfiles just returns the path. If the file doesn't exist in the manifest, then path.is_file will return false, but the command will still succeed

FWIW, I had a very similar issue. I had the following error message pop up: ``` FATAL: bazel crashed due to an internal error. Printing stack trace: java.lang.UnsatisfiedLinkError: 'void com.google.devtools.build.lib.profiler.SystemNetworkStats.getNetIfAddrsNative(java.util.List)'...

I was using last_green from a few days ago. I can confirm that when I sync to head your fix appears to work for my specific issue.

Note: this affects `cargo_build_script` rules in rules_rust ([source](https://github.com/bazelbuild/rules_rust/blob/df80ce61e418ea1c45c5bd51f88a440a7fb9ebc9/cargo/private/cargo_build_script.bzl#L208-L214)), and probably affects `rules_foreign_cc`, though I haven't checked that.

I don't currently have a small repro, I can see if I can come up with one next week.

Upon digging deeper, maybe we should just be deprecating these attributes. They don't make much sense with action configs * We have a single `cc_toolchain.compiler_executable`, but with action configs, we...

Was going to close this since it didn't seem to be an issue, but just realized I should probably reopen it for the deprecation.