Matt

Results 150 comments of Matt

My concern with a lock-based approach to snapshotting is that of performance. Since watchman will trigger an snapshot every time a file is written, which for an IDE such as...

I'm not familiar enough with your PR to know whether it was the cause of it, but my jj was hanging, and I managed to fix it by deleting both...

It's only happened once, so I'm not sure. * I'm running linux * It's not a network filesystem * It was on the jj repo itself, so not an especially...

I was able to reproduce this problem. I'm not entirely sure what the root cause is, but: * This time I was using a combination of `jj` built from head...

Notes for reviewers to make your life easier. I recommend reviewing in the following order: 1) Start with `test_config_security.rs` to see the UX 1) Then go to `user_config.proto` then `user_config.rs`...

@yuja There's clearly been a lot of contention with the UX issues, so I've been rethinking from the ground up, and realized that if I added a concept of a...

> According to #7465, you probably want to remove more options from `diffmove`, like `-r` or `-A/-B/-d`. And maybe make `--from` allow a single revision. Done > Also I'm not...

> Again, it sounds more like implementation details. They aren't implementation details though, because it affects how squash behaves in a meaningful way to a user. `jj squash` abandons a...

> > It's not an implementation detail because, for example, I frequently don't want jj to abandon a commit that I was squashing from, or to combine the descriptions. >...

> It is very relevant, when you refer to choosing which command to use by knowing what is in the revision! How can you say it's not relevant that your...