OneTimePassword icon indicating copy to clipboard operation
OneTimePassword copied to clipboard

replace base32 implementation

Open mrgrauel opened this issue 3 years ago β€’ 3 comments

Based on @mattrubin feedback https://github.com/mattrubin/OneTimePassword/pull/227#issuecomment-841852339

  • removes "mattrubin/Base32"
  • adds "norio-nomura/Base32"

mrgrauel avatar Aug 10 '21 13:08 mrgrauel

Codecov Report

Merging #234 (80e6f6f) into develop (bd2a8fa) will decrease coverage by 5.21%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #234      +/-   ##
===========================================
- Coverage    96.97%   91.75%   -5.22%     
===========================================
  Files            6        6              
  Lines          364      364              
===========================================
- Hits           353      334      -19     
- Misses          11       30      +19     
Impacted Files Coverage Ξ”
Sources/Token+URL.swift 99.13% <100.00%> (+0.86%) :arrow_up:
Sources/Crypto.swift 51.21% <0.00%> (-48.79%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update bd2a8fa...80e6f6f. Read the comment docs.

codecov[bot] avatar Aug 10 '21 13:08 codecov[bot]

@mattrubin the codecov is reduced cause of the travis-ci configuration. It doesn't run any iOS 13+ simulator. Do you have a good idea how to fix it with GitHub Actions? As you can see here the pipelines do succeed but run in the origin repo πŸ€”

mrgrauel avatar Aug 10 '21 13:08 mrgrauel

@mattrubin all good?

mrgrauel avatar Sep 15 '21 06:09 mrgrauel